-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: add pprof support #138
metrics: add pprof support #138
Conversation
Create new function `RegisterPprofToServer` to enable pprof profiling on the existing metrics server. This can be used to gain useful insights on the performance of the application.
|
Welcome @Fricounet! |
Hi @Fricounet. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @jsafrane |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fricounet, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Create new function
RegisterPprofToServer
to enable pprof profiling on the existing metrics server. This can be used to gain useful insights on the performance of the application.Which issue(s) this PR fixes:
Fixes #137
Special notes for your reviewer:
I tested the modified lib buy building locally one of the CSI sidecars and deploying it to a test cluster. I was able to access the pprof endpoints with a curl form inside the container.
Does this PR introduce a user-facing change?: