Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all grpc connections need metrics #143

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Not all grpc connections need metrics #143

merged 1 commit into from
Aug 11, 2023

Conversation

gnufied
Copy link
Contributor

@gnufied gnufied commented Aug 11, 2023 •
edited

GRPC client connection that node registrar makes, as such doesn't need metrics and hence allow connections to be made without metrics

Add support for metric-less grpc connection

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 11, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 11, 2023
@gnufied
Not all grpc connections need metrics
20b8416 
GRPC client connection that node register makes as such doesn't need
metrics and hence allow connections to be made without metrics
@gnufied gnufied force-pushed the allow-connection-without-metrics branch from 0d6f2a3 to 20b8416 Compare August 11, 2023 19:50
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2023
@dobsonj
Copy link
Member

dobsonj commented Aug 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0f69380 into kubernetes-csi:master Aug 11, 2023
2 of 3 checks passed
@Fricounet Fricounet mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-griffith j-griffith Awaiting requested review from j-griffith

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees

@xing-yang xing-yang

@dobsonj dobsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnufied @dobsonj @xing-yang @k8s-ci-robot