GitHub actions running go fmt check on a Windows machine complains about file format endings #259
Assignees
Comments
|
/assign @alexander-ding |
This was referenced Oct 18, 2022
TerryHowe
added a commit
to TerryHowe/csi-proxy
that referenced
this issue
Dec 9, 2024
98f2307 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version e9d8712 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root faf79ff Remove --kube-root deprecated kind argument 734c2b9 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch f95c855 Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966 Treat main branch as equivalent to master branch e31de52 Merge pull request kubernetes-csi#261 from huww98/golang fd153a9 Bump golang to 1.23.1 a8b3d05 pull-test.sh: fix "git subtree pull" errors 6b05f0f use new GOTOOLCHAIN env to manage go version 18b6ac6 chore: update CSI driver version to 1.15 git-subtree-dir: release-tools git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
As discussed in this PR, the automatic GitHub action for Windows unit tests is running on a Windows machine, where
gofmtexpects \n\r line endings in files. However, the files checked in in this repository use Linux style \n line endings, which causesgofmtto complain. This doesn't show up in local Linux development machines and have been silent as GitHub actions only care about the return code of the final command in a multi-line run command. Thegofmtcheck is only the first line, so the error is logged but doesn't fail the entire action.What you expected to happen:
The
gofmtcheck, as well as other Makefile checks, should happen on a Linux machine. The actual unit tests can happen in its own separate task.How to reproduce it:
Any pull request onto master should trigger the workflow. Check the log for the unit tests.
Anything else we need to know?:
Environment:
Not relevant.
The text was updated successfully, but these errors were encountered: