-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owners: introduce aliases #155
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md | ||
|
|
||
| aliases: | ||
|
|
||
| # SIG-Storage chairs and leads should always have approval rights in all repos. | ||
| # Others may be added as needed here or in each repo. | ||
| kubernetes-csi-approvers: | ||
| - jsafrane | ||
| - msau42 | ||
| - saad-ali | ||
| - xing-yang | ||
|
|
||
| # Reviewers are automatically assigned to new PRs. The following | ||
| # reviewers will be active in all repos. Other reviewers can be | ||
| # added in each repo. | ||
| # | ||
| # Reviewers are encouraged to set the "Busy" flag in their GitHub status | ||
| # when they are temporarily unable to review PRs. | ||
| kubernetes-csi-reviewers: | ||
| - andyzhangx | ||
| - chrishenzie | ||
| - ggriffiths | ||
| - gnufied | ||
| - j-griffith | ||
| - Jiawei0227 | ||
| - jingxu97 | ||
| - jsafrane | ||
| - pohly | ||
| - xing-yang | ||
|
|
||
| # This documents who previously contributed to Kubernetes-CSI | ||
| # as approver. | ||
| emeritus_approver: | ||
| - lpabon | ||
| - sbezverk | ||
| - vladimirvivien | ||
|
|
||
| # This documents who previously contributed to Kubernetes-CSI | ||
| # as reviewer. | ||
| emeritus_reviewer: | ||
| - lpabon | ||
| - saad-ali | ||
| - sbezverk | ||
| - vladimirvivien | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,8 @@ | ||
| # See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md | ||
|
|
||
| approvers: | ||
| - saad-ali | ||
| - msau42 | ||
| - kubernetes-csi-approvers | ||
| - pohly | ||
|
|
||
| reviewers: | ||
| - saad-ali | ||
| - msau42 | ||
| - pohly | ||
| - kubernetes-csi-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| KUBERNETES_CSI_OWNERS_ALIASES |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add @gnufied @Jiawei0227 @ggriffiths to the list of reviewers.
@j-griffith you ok with becoming a reviewer for all kubernetes-csi repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't intention on my part, I copied j-griffith when I should have used ggriffiths. But good that I did, now we have two griffiths 😄
Done.