-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to generate patch release notes #237
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-none |
ed38efa
to
4a06ec2
Compare
@pohly are these tests failing an indication that we did not update release-tools correctly in the other repos? I tried running the git subtree commands manually on my own fresh external-provisioner branch and it gave strange results.
|
At first glance, kubernetes-csi/external-provisioner#1050 looks normal. It also works for me: $ cd /nvme/gopath/src/github.com/kubernetes-csi/csi-release-tools
$ gh pr checkout --detach https://github.com/kubernetes-csi/csi-release-tools/pull/237
remote: Enumerating objects: 6, done.
....
HEAD is now at 2c625d41 Add script to generate patch release notes
$ cd /nvme/gopath/src/github.com/kubernetes-csi/external-provisioner
$ git fetch origin && git checkout origin/master
...
$ git subtree pull --squash --prefix=release-tools /nvme/gopath/src/github.com/kubernetes-csi/csi-release-tools 2c625d41dda606064eeb1c602e307bc399f4b451
....
Resolving deltas: 100% (282/282), completed with 12 local objects.
From /nvme/gopath/src/github.com/kubernetes-csi/csi-release-tools
* branch 2c625d41dda606064eeb1c602e307bc399f4b451 -> FETCH_HEAD
hint: Waiting for your editor to close the file... Waiting for Emacs...
Merge made by the 'recursive' strategy.
release-tools/SIDECAR_RELEASE_PROCESS.md | 77 ++++++++++++++++++++++++++++++++++-------------------------------------------
release-tools/generate_patch_release_notes.sh | 106 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 140 insertions(+), 43 deletions(-)
create mode 100755 release-tools/generate_patch_release_notes.sh
pohly@pohly-desktop:/nvme/gopath/src/github.com/kubernetes-csi/external-provisioner$ git log
commit 9ad994318759084d8806e6156f38d0ef86dddda0 (HEAD)
Merge: ae4c14dfe ff7abf467
Author: Patrick Ohly <patrick.ohly@intel.com>
Date: Thu Oct 19 16:01:31 2023 +0200
Merge commit 'ff7abf46771655009bc14798960f41887d7e0063' into HEAD
commit ff7abf46771655009bc14798960f41887d7e0063
Author: Patrick Ohly <patrick.ohly@intel.com>
Date: Thu Oct 19 16:01:31 2023 +0200
Squashed 'release-tools/' changes from f9d5b9c05..2c625d41d
2c625d41d Add script to generate patch release notes
git-subtree-dir: release-tools
git-subtree-split: 2c625d41dda606064eeb1c602e307bc399f4b451
commit ae4c14dfe82168a00304ebaf0d991ef61869ab78 (origin/master, origin/HEAD)
... It also works when I merge your PR into master and then use |
/retest |
/lgtm |
Sample PR: kubernetes-csi/external-provisioner#1061