Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support make container on arm64 architecture #59

Closed
wants to merge 1 commit into from
Closed

Support make container on arm64 architecture #59

wants to merge 1 commit into from

Conversation

wangzihao3
Copy link

@wangzihao3 wangzihao3 commented Dec 31, 2019 •
edited
Loading

Fixes kubernetes-csi/external-provisioner#381

- judge the arch in build.make, set BASE_IMAGE to discolix/static:latest
  when ARCH is arm64.
- todo: need to modify the FROM part in Dockerfile.

Signed-off-by: wangzihao wangzihao18@huawei.com

@wangzihao3
Support make container on arm64 architecture
b65aedd 
- judge the arch in build.make, set BASE_IMAGE to discolix/static:latest
  when ARCH is arm64.

Signed-off-by: wangzihao <wangzihao18@huawei.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Wangzihao18
To complete the pull request process, please assign saad-ali
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and pohly December 31, 2019 01:46
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 31, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @Wangzihao18!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Wangzihao18. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 31, 2019
@wangzihao3 wangzihao3 mentioned this pull request Dec 31, 2019
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 31, 2019
msau42
msau42 reviewed Jan 2, 2020
View reviewed changes
build.make
# Specific BASE_IMAGE for different arch, default BASE_IMAGE gcr.io/distroless is for x86, discolix/static is for arm.
BASE_IMAGE=gcr.io/distroless/static:latest
ifeq (${ARCH}, arm64)
BASE_IMAGE=discolix/static:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't seem very widely used. I am checking to see if the Kubernetes project has another recommended base image for arm

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @msau42. I found it in this repo https://github.com/discolix/discolix.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

@wangzihao3: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 2, 2020
@pohly
Copy link
Contributor

pohly commented May 29, 2020

Superseded by PR #87, except that arm64 is not enabled yet?

@cyb70289
Copy link
Contributor

Superseded by PR #87, except that arm64 is not enabled yet?

Hi @pohly , I see arm64 is not enabled in prow.sh, CSI_PROW_BUILD_PLATFORMS configvar.
Is it possible to enabled arm64 build? I can help with a PR. Thanks.

@pohly
Copy link
Contributor

pohly commented Jun 12, 2020

@cyb70289 yes, please verify that all of the Kubernetes-CSI repos build for ARM, then submit a PR against csi-release-tools which adds arm64. That then will be rolled out to the other repos before the next sidecar releases.

@cyb70289
Copy link
Contributor

@pohly thank you. I tested node-driver-registrar, external-attacher, external-privisioner, external-snapshotter, external-resizer, livenessprobe, csi-driver-host-path.
They all build cleanly on Arm64. I tried make build and make container.
Is it okay I propose a PR to enable Arm64 in csi release tool?

@pohly
Copy link
Contributor

pohly commented Jun 15, 2020

Yes, please do.

@cyb70289
Copy link
Contributor

PR created #91

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@pohly pohly Awaiting requested review from pohly

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi-arch image
6 participants
@wangzihao3 @k8s-ci-robot @fejta-bot @pohly @cyb70289 @msau42