Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ControllerExpandVolume tests for Online expansion. #203

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Implement ControllerExpandVolume tests for Online expansion. #203

merged 1 commit into from
Jun 21, 2019

Conversation

Ntr0
Copy link
Contributor

@Ntr0 Ntr0 commented Jun 17, 2019 •
edited
Loading

Adds tests for ControllerExpandVolume capability. Tests for OFFLINE
VolumeExpansion are not included.

What type of PR is this?

/kind test-case

What this PR does / why we need it:
csi-test do not support ControllerExpandVolume capability yet. This PR adds three very basic tests for this.
Which issue(s) this PR fixes:

Special notes for your reviewer:
Not sure about the /kind test-case but there was no fitting kind ;)

Does this PR introduce a user-facing change?:

Added tests for ControllerExpandVolume

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @Ntr0!

It looks like this is your first PR to kubernetes-csi/csi-test 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-test has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 17, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Ntr0. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2019
@Ntr0
Copy link
Contributor Author

Ntr0 commented Jun 17, 2019

/assign @msau42

@Ntr0
Copy link
Contributor Author

Ntr0 commented Jun 17, 2019

@msau42 CI fails because forgot to gofmt the code. Unfortunately i cannot retrigger the test.

@gnufied
Copy link
Contributor

gnufied commented Jun 17, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2019
@gnufied
Copy link
Contributor

gnufied commented Jun 17, 2019

/retest

@msau42
Copy link
Collaborator

msau42 commented Jun 17, 2019

/assign @gnufied

@gnufied
Copy link
Contributor

gnufied commented Jun 17, 2019

Can you squash the commits?

gnufied
gnufied reviewed Jun 18, 2019
View reviewed changes
pkg/sanity/controller.go Outdated Show resolved Hide resolved
Implement ControllerExpandVolume tests for Online expansion.
dccc5cf 
Adds tests for ControllerExpandVolume capability. Tests for OFFLINE
VolumeExpansion are not included.
@Ntr0
Copy link
Contributor Author

Ntr0 commented Jun 20, 2019

@gnufied could you please re-review?

@gnufied
Copy link
Contributor

gnufied commented Jun 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@msau42
Copy link
Collaborator

msau42 commented Jun 20, 2019

Thanks!

Can you also update the release note to say that tests for online ControllerExpandVolume are added?

@msau42
Copy link
Collaborator

msau42 commented Jun 20, 2019

/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, Ntr0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 20, 2019
@Ntr0
Copy link
Contributor Author

Ntr0 commented Jun 21, 2019

@msau42 Done.

@msau42
Copy link
Collaborator

msau42 commented Jun 21, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 65a7181 into kubernetes-csi:master Jun 21, 2019
suneeth51 pushed a commit to suneeth51/csi-test that referenced this pull request Sep 11, 2019
@k8s-ci-robot
Merge pull request kubernetes-csi#203 from StratoAG/ControllerExpandV…
e87cabd 
…olume

Implement ControllerExpandVolume tests for Online expansion.
stmcginnis pushed a commit to stmcginnis/csi-test that referenced this pull request Oct 9, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#203 from humblec/test-vendor
cfa5a75 
 release tools update to 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@pohly pohly Awaiting requested review from pohly

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ntr0 @k8s-ci-robot @gnufied @msau42