Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up configuration handling #233

Merged
merged 2 commits into from
Nov 13, 2019
Merged

clean up configuration handling #233

merged 2 commits into from
Nov 13, 2019

Commits on Nov 6, 2019

  1. sanity: clean up configuration handling 

    NewTestConfig now must be used to initialize the struct with
defaults. This makes it easier to introduce new fields where the empty
value isn't a suitable default. To ensure that callers adapt to the
new semantic, the struct gets renamed. This also allows removing
replicated default values all over the source code.

SanityContext gets renamed to TestContext for consistency. Its new
Finalize method should be used to clean up. To allow that, GinkgoTest
returns the context pointer.
    @pohly
    pohly committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    00e10f7 View commit details
    Browse the repository at this point in the history

  2. sanity: specify timeouts as durations 

    This is cleaner. This also changes the values of the command line
timeout parameters from plain int (10) to durations (10s), but this is
okay as we are preparing a major new release.
    @pohly
    pohly committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    90f9d07 View commit details
    Browse the repository at this point in the history