Initial tests for GroupController Server and VolumeGroupSnapshot Service #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
nixpanic
force-pushed
the
GroupControllerServer
branch
2 times, most recently
from
18dbf72
to
2d4cc5d
Compare
nixpanic
added a commit
to nixpanic/csi-driver-host-path
that referenced
this pull request
Jun 19, 2023
nixpanic
added a commit
to nixpanic/csi-driver-host-path
that referenced
this pull request
Jun 19, 2023
xing-yang
reviewed
Jun 19, 2023
These initial tests are very minimal, and only validate the availability of the VolumeGroupSnapshot Service of the GroupController Service. No VolumeGroupSnapshots are made (yet).
nixpanic
force-pushed
the
GroupControllerServer
branch
from
2d4cc5d
to
e27f8ab
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
nixpanic
added a commit
to nixpanic/csi-driver-host-path
that referenced
this pull request
Jun 20, 2023
nixpanic
added a commit
to nixpanic/csi-driver-host-path
that referenced
this pull request
Aug 7, 2023
nixpanic
added a commit
to nixpanic/csi-driver-host-path
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The GroupContoller server is a new component in the CSI Specification. It offers the VolumeGroupSnapshot service, for which tests are added with this PR.
Which issue(s) this PR fixes:
Fixes #455
Special notes for your reviewer:
These initial tests are very minimal, and only validate the availability of the VolumeGroupSnapshot Service of the GroupController Service. No VolumeGroupSnapshots are made (yet).
Does this PR introduce a user-facing change?: