Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attacher should use storage.k8s.io/v1beta1 API instead of v1alpha1 #39

Closed
jsafrane opened this issue Mar 15, 2018 · 4 comments
Closed
Assignees

Comments

@jsafrane
Copy link
Contributor

Currently, attacher uses storage.k8s.io/v1alpha1 API to talk to Kubernetes and work with VOlumeAttachment objects. v1alpha1 needs to be explicitly enabled by cluster admins.

We should move to v1beta1, which is enabled by default.

@pohly
Copy link
Contributor

pohly commented Mar 15, 2018

Is this issue only about k8s.io/api/storage/v1alpha1 or also about k8s.io/client-go/informers/storage/v1alpha1 and k8s.io/client-go/listers/storage/v1beta1?

k8s.io/api/storage seems to be a simple search/replace, but k8s.io/client-go is a bit more involved, because the newer API deals with StorageClass instances, not VolumeAttachment.

@pohly
Copy link
Contributor

pohly commented Mar 15, 2018

Probably all of them, because vendor/k8s.io/client-go/listers/storage/v1alpha1/volumeattachment.go uses the k8s.io/api/storage/v1alpha1 API...

The latest API for k8s.io/client-go is v1, not v1beta1. Same for vendor/k8s.io/api/storage. Shouldn't we use v1 then instead of v1beta1?

@saad-ali
Copy link
Member

@sbezverk has volunteered to work on this.

@jsafrane
Copy link
Contributor Author

jsafrane commented Apr 3, 2018

Fixed by #40

@jsafrane jsafrane closed this as completed Apr 3, 2018
jsafrane pushed a commit to jsafrane/external-attacher that referenced this issue Sep 27, 2022
Bug 2097284: Rebase to v3.5.0 for OCP 4.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants