fix default leader election type #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
|
/assign @msau42 |
msau42
reviewed
Apr 24, 2019
cmd/csi-attacher/main.go
Outdated
| @@ -66,7 +66,7 @@ var ( | |||
| retryIntervalMax = flag.Duration("retry-interval-max", 5*time.Minute, "Maximum retry interval of failed create volume or deletion.") | |||
|
|
|||
| enableLeaderElection = flag.Bool("leader-election", false, "Enable leader election.") | |||
| leaderElectionType = flag.String("leader-election-type", "configmap", "the type of leader election, options are 'configmaps' (default) or 'leases' (recommended). The 'configmaps' option is deprecated in favor of 'leases'.") | |||
| leaderElectionType = flag.String("leader-election-type", "configmaps", "the type of leader election, options are 'configmaps' (default) or 'leases' (recommended). The 'configmaps' option is deprecated in favor of 'leases'.") | |||
There was a problem hiding this comment.
Can we define constants for these? It could help avoid typos in the future
There was a problem hiding this comment.
Good suggestion, already updated, PTAL :)
mlmhl
force-pushed
the
leader-electino-type
branch
from
28ded6d to
a53ef38
Compare
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlmhl, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 26, 2019
Cherry pick #144 to release-1.1: fix default leader election type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The valid leader election types are
configmapsandleases, but the default value of flagleaderElectionTypeisconfigmap, which is illegal. This PR changes the default value toconfigmaps.Special notes for your reviewer:
Does this PR introduce a user-facing change?: