-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid logging PV name,where PV created by other CSI #195
Conversation
Hi @Madhu-1. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some unit test(s) into csi_handler_test.go.
1c4806e
to
26a390f
Compare
/ok-to-test |
26a390f
to
574f14a
Compare
Now that we have the naming right, can you please add unit tests that make sure the attacher ignores PVs with non-CSI source or with wrong CSI driver? |
working on it |
currently attacher is logging the pv name which is created by other driver, This PR adds a check to make sure PV is created by same driver. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
574f14a
to
6900ef7
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
currently, attacher is logging the PV name which is created by other drivers, This PR
adds a check to make sure PV is created by the same driver.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com
Which issue(s) this PR fixes:
Fixes #194
Special notes for your reviewer:
Does this PR introduce a user-facing change?: