Add go ldflags using LDFLAGS at the time of compilation

[bnrjee]

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR allows adding ldflags while running make. We are trying build a binary without debug info. With this change we will be able to pass -s flag as an argument to Makefile.

Which issue(s) this PR fixes:

Fixes #264

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add go ldflags using LDFLAGS at the time of compilation.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bnrjee
To complete the pull request process, please assign saad-ali after the PR has been reviewed.
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• release-tools/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @bnrjee!

It looks like this is your first PR to kubernetes-csi/external-attacher 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-attacher has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bnrjee. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bnrjee]

Tests performed,
1>Made sure that the build is without debug info and repeatable.
2>Made sure that the default behavior has not been altered.

[root@ip-172-31-13-77 external-attacher]# make BUILD_PLATFORMS="linux amd64" LDFLAGS="-s -w -buildid='' -X main.version=`git describe --long --tags --match='v*' --dirty 2>/dev/null || git rev-list -n1 HEAD` -extldflags "-static"" 
./release-tools/verify-go-version.sh "go"
mkdir -p bin
echo 'linux amd64' | tr ';' '\n' | while read -r os arch suffix; do \
	if ! (set -x; CGO_ENABLED=0 GOOS="$os" GOARCH="$arch" go build  -a -ldflags '-s -w -buildid='' -X main.version=v3.0.0-15-ge463682c -extldflags -static' -o "./bin/csi-attacher$suffix" ./cmd/csi-attacher); then \
		echo "Building csi-attacher for GOOS=$os GOARCH=$arch failed, see error(s) above."; \
		exit 1; \
	fi; \
done
+ CGO_ENABLED=0
+ GOOS=linux
+ GOARCH=amd64
+ go build -a -ldflags '-s -w -buildid= -X main.version=v3.0.0-15-ge463682c -extldflags -static' -o ./bin/csi-attacher ./cmd/csi-attacher
[root@ip-172-31-13-77 external-attacher]# file bin/csi-attacher 
bin/csi-attacher: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
[root@ip-172-31-13-77 external-attacher]# sha256sum bin/csi-attacher 
4ebcbec9aa0e99deec70e0c8970ed505f373bcbe0bdecbbbf0d70eaf44b4a927  bin/csi-attacher
[root@ip-172-31-13-77 external-attacher]# make clean
rm -rf bin
[root@ip-172-31-13-77 external-attacher]# make BUILD_PLATFORMS="linux amd64" LDFLAGS="-s -w -buildid='' -X main.version=`git describe --long --tags --match='v*' --dirty 2>/dev/null || git rev-list -n1 HEAD` -extldflags "-static"" 
./release-tools/verify-go-version.sh "go"
mkdir -p bin
echo 'linux amd64' | tr ';' '\n' | while read -r os arch suffix; do \
	if ! (set -x; CGO_ENABLED=0 GOOS="$os" GOARCH="$arch" go build  -a -ldflags '-s -w -buildid='' -X main.version=v3.0.0-15-ge463682c -extldflags -static' -o "./bin/csi-attacher$suffix" ./cmd/csi-attacher); then \
		echo "Building csi-attacher for GOOS=$os GOARCH=$arch failed, see error(s) above."; \
		exit 1; \
	fi; \
done
+ CGO_ENABLED=0
+ GOOS=linux
+ GOARCH=amd64
+ go build -a -ldflags '-s -w -buildid= -X main.version=v3.0.0-15-ge463682c -extldflags -static' -o ./bin/csi-attacher ./cmd/csi-attacher
[root@ip-172-31-13-77 external-attacher]# sha256sum bin/csi-attacher 
4ebcbec9aa0e99deec70e0c8970ed505f373bcbe0bdecbbbf0d70eaf44b4a927  bin/csi-attacher
[root@ip-172-31-13-77 external-attacher]# file bin/csi-attacher 
bin/csi-attacher: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
[root@ip-172-31-13-77 external-attacher]# make clean
rm -rf bin
[root@ip-172-31-13-77 external-attacher]# make BUILD_PLATFORMS="linux amd64" 
./release-tools/verify-go-version.sh "go"
mkdir -p bin
echo 'linux amd64' | tr ';' '\n' | while read -r os arch suffix; do \
	if ! (set -x; CGO_ENABLED=0 GOOS="$os" GOARCH="$arch" go build  -a -ldflags '-X main.version=v3.0.0-15-ge463682c -extldflags "-static" ' -o "./bin/csi-attacher$suffix" ./cmd/csi-attacher); then \
		echo "Building csi-attacher for GOOS=$os GOARCH=$arch failed, see error(s) above."; \
		exit 1; \
	fi; \
done
+ CGO_ENABLED=0
+ GOOS=linux
+ GOARCH=amd64
+ go build -a -ldflags '-X main.version=v3.0.0-15-ge463682c -extldflags "-static" ' -o ./bin/csi-attacher ./cmd/csi-attacher
[root@ip-172-31-13-77 external-attacher]# sha256sum bin/csi-attacher 
17802dd2b847967cb1b4224de370885a4d5f889088340c5c4de76d2badf5c56f  bin/csi-attacher
[root@ip-172-31-13-77 external-attacher]# file bin/csi-attacher 
bin/csi-attacher: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped
[root@ip-172-31-13-77 external-attacher]# 

[jsafrane]

@bnrjee, please submit a PR against https://github.com/kubernetes-csi/csi-release-tools, content of release-tools/ is copied from there. And it will fix all other CSI repos too.

[bnrjee]

@bnrjee, please submit a PR against https://github.com/kubernetes-csi/csi-release-tools, content of release-tools/ is copied from there. And it will fix all other CSI repos too.

I have created this PR
kubernetes-csi/csi-release-tools#108

[k8s-ci-robot]

@bnrjee: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

/close

Merged via csi-release-tools.

[k8s-ci-robot]

@pohly: Closed this PR.

In response to this:

/close

Merged via csi-release-tools.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.