No credential in DeleteVolume RPC when defined StorageClass for PV is deleted already

[sarjeet2013]

Observed the behavior when receiving RPC call for DeleteVolume and doesn't contain the credentials passed in the Storage Class.

The issue seems to be not handling it for case where StorageClass is deleted before the RPC request for DeleteVolume is in progress:

https://github.com/kubernetes-csi/external-provisioner/blob/master/pkg/controller/controller.go#L761
pkg/controller/controller.go:761
if storageClass, err := p.client.StorageV1().StorageClasses().Get(storageClassName, metav1.GetOptions{}); err == nil {

From above The error condition is not implemented when there is a storageclass defined but the storageClass is deleted before the PVC deletion in progress
In that case, the DeleteVolume request only send VolumeId without secrets

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[msau42]

I believe #274 does this now and passes no secret on delete if it can't find it.

/close

[k8s-ci-robot]

@msau42: Closing this issue.

In response to this:

I believe #274 does this now and passes no secret on delete if it can't find it.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.