Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release with latest translation-lib #563

Closed
mattcary opened this issue Feb 11, 2021 · 19 comments
Closed

Make release with latest translation-lib #563

mattcary opened this issue Feb 11, 2021 · 19 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mattcary
Copy link

Should happen before 1.21 release.

kubernetes/kubernetes#97823 has the changes we want.

/cc @Jiawei0227

@pohly
Copy link
Contributor

pohly commented Feb 11, 2021

#564 should also be included in that release.

@mattcary
Copy link
Author

mattcary commented Feb 11, 2021

Also the new migration metrics, kubernetes-csi/csi-lib-utils#77.

@chrigl
Copy link

chrigl commented Feb 16, 2021

kubernetes/kubernetes#98311 would be great as well. It is already on release-1.20 (not tagged yet) and tag v1.21.0-alpha.3.

@andyzhangx
Copy link
Member

@msau42 @Jiawei0227 could you help release 2.1.1 version, it has one critical csi migration fix, thanks.

@Jiawei0227
Copy link
Contributor

@andyzhangx I will create a release-note after #567 being merged tomorrow.

@pohly
Copy link
Contributor

pohly commented Feb 22, 2021

Can we also get #565 included?

@pohly
Copy link
Contributor

pohly commented Feb 22, 2021

It looks like v2.1.0 was tagged on master and all changes since then are bug fixes for a v2.1.1 release or build fixes that we need to test that release on Kubernetes 1.20:
v2.1.0...master

I would be okay to just tag v2.1.1 on master. We can also create a release-2.1 branch, it just would be identical to master for now.

@msau42
Copy link
Collaborator

msau42 commented Feb 22, 2021

I will create a release branch so that we're consistent in our release process. I think the release-notes tool doesn't support patch releases on master branch when using a discover method.

@msau42
Copy link
Collaborator

msau42 commented Feb 23, 2021

release-2.1 is created. I took everything up until (not including) #560 as that change potentially requires action from consumers of migrated plugins.

For any bug fixes after that release-2.1...master, please open a cherry-pick PR

@pohly
Copy link
Contributor

pohly commented Feb 23, 2021

Here's the one I care about: #568

@pohly
Copy link
Contributor

pohly commented Mar 10, 2021

I'm checking the release-2.1 branch.

Can we also get #565 included?

Done, through PR #568.

kubernetes/kubernetes#98311 would be great as well

That implies bumping k8s.io/csi-translation-lib to a version > v1.21.0-alpha.3. I don't think we should be doing that in a release branch, but I am not sure. @msau42, @jsafrane, what do you think?

Also the new migration metrics, kubernetes-csi/csi-lib-utils#77.

Should not be included according to @msau42 ("that change potentially requires action from consumers of migrated plugins").

As it looks like we don't have other pending fixes, I went ahead and prepared release notes:
#578

@msau42
Copy link
Collaborator

msau42 commented Mar 10, 2021

I think we should update csi-translation-lib in the patch release. It contains a number of fixes for many plugins. @Jiawei0227 can you help with that?

@ialidzhikov
Copy link
Contributor

I think this issue can be closed as new releases that vendor the latest csi-translation-lib were cut - v2.1.1, v2.2.0.

@pohly
Copy link
Contributor

pohly commented May 5, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@pohly: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pohly
Copy link
Contributor

pohly commented May 5, 2021

/reopen

#621 is still pending?

@k8s-ci-robot
Copy link
Contributor

@pohly: Reopened this issue.

In response to this:

/reopen

#621 is still pending?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 5, 2021
@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2021
@Jiawei0227
Copy link
Contributor

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

9 participants