fix: introduce /v5 module suffix for go.mod

[jakobmoellerdev]

changes the go.mod path to add /v5 so that go module is resolved properly

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Adds the /v5 suffix that was missed on previous releases so that the go.mod resolves properly

Special notes for your reviewer:

Opened as per request on https://kubernetes.slack.com/archives/C09QZFCE5/p1718782253879689

Does this PR introduce a user-facing change?:

action required: go module path was changed to github.com/kubernetes-csi/external-provisioner/v5, adjust accordingly when importing in go

[k8s-ci-robot]

Hi @jakobmoellerdev. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[msau42]

/ok-to-test

[jakobmoellerdev]

@msau42 I think

external-provisioner/.prow.sh

Line 3 in c66e140

CSI_PROW_SIDECAR_E2E_IMPORT_PATH="github.com/kubernetes-csi/external-provisioner/v5/test/e2e"

is problematic because it is both a go import path as well as a directory path and now these 2 diverge with the /v5 bump. I believe that release tooling uses it as a path in

external-provisioner/release-tools/prow.sh

Line 1038 in e96448a

cd "${GOPATH}/src/${CSI_PROW_SIDECAR_E2E_IMPORT_PATH}" &&

and as a go import in

external-provisioner/release-tools/prow.sh

Line 977 in e96448a

run_with_go "${CSI_PROW_GO_VERSION_BUILD}" go test -c -o "${CSI_PROW_WORK}/e2e-local.test" "${CSI_PROW_SIDECAR_E2E_IMPORT_PATH}"

Any preference on how to fix that?

[msau42]

@jakobmoellerdev What do you think of creating a new variable? Edits to release-tools need to be done in https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh? first and than imported here as a git submodule (instructions are in the repo)

[jakobmoellerdev]

@msau42 I would need a checkup on the tools PR so that we can unblock that.

[jakobmoellerdev]

/retest

[jakobmoellerdev]

@msau42 thanks to the adjustment in the release tooling this one is now good to go 👍

[msau42]

/lgtm
/approve

Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment