filter resizer related params from storageclass before passing them to the driver #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @msau42 |
msau42
reviewed
Mar 20, 2019
| @@ -571,6 +574,8 @@ func removePrefixedParameters(param map[string]string) (map[string]string, error | |||
| case prefixedNodeStageSecretNamespaceKey: | |||
| case prefixedNodePublishSecretNameKey: | |||
| case prefixedNodePublishSecretNamespaceKey: | |||
| case prefixedResizerSecretNameKey: | |||
| case prefixedResizerSecretNamespaceKey: | |||
There was a problem hiding this comment.
can you also update the unit test?
k8s-ci-robot
added
size/XL
msau42
reviewed
Mar 20, 2019
.idea/external-provisioner.iml
Outdated
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
also remove these ide files?
There was a problem hiding this comment.
Oh sorry, I forgot to check the commit change. Already removed, PTAL :)
k8s-ci-robot
added
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlmhl, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
Corrections in the attacher sidecar documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external resizer introduces two StorageClass parameters used by resizing secret: https://github.com/kubernetes-csi/external-resizer/blob/25e836c8513f0d31df3604981f1312f0db376e45/pkg/resizer/csi_resizer.go#L45
The external provisioner should remove these parameters before passing to the driver.