Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to Go 1.12.4 #267

Merged
merged 2 commits into from
Apr 15, 2019
Merged

update to Go 1.12.4 #267

merged 2 commits into from
Apr 15, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Apr 15, 2019 •
edited by msau42
Loading 

Update build to Go 1.12.4

pohly added 2 commits April 15, 2019 09:45
@pohly
update to Go 1.12.4
e157b6b 
Kubernetes also requires 1.12. We pick the latest stable release
for CI builds.
@pohly
Merge commit 'e157b6b514ace191f46d4c879491cb7d11684659' into release-…
73194b7 
…tools
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 15, 2019 08:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2019
@pohly pohly marked this pull request as ready for review April 15, 2019 09:02
@pohly
Copy link
Contributor Author

pohly commented Apr 15, 2019

/test pull-kubernetes-csi-external-provisioner-1-13-on-kubernetes-1-13
/test pull-kubernetes-csi-external-provisioner-1-13-on-kubernetes-master
/test pull-kubernetes-csi-external-provisioner-1-14-on-kubernetes-1-14
/test pull-kubernetes-csi-external-provisioner-1-14-on-kubernetes-master
/test pull-kubernetes-csi-external-provisioner-alpha-1-13-on-kubernetes-1-13
/test pull-kubernetes-csi-external-provisioner-alpha-1-14-on-kubernetes-1-14
/test pull-kubernetes-csi-external-provisioner-unit

@pohly pohly changed the title WIP: update to Go 1.12.4 update to Go 1.12.4 Apr 15, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 66fd58e into kubernetes-csi:master Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 17, 2019
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
@k8s-ci-robot
Merge pull request kubernetes-csi#267 from linux-on-ibm-z/distroless-…
61d61ae 
…revert

Revert to multiarch distroless base image
avorima added a commit to avorima/external-provisioner that referenced this pull request Dec 11, 2024
@avorima
Squashed 'release-tools/' changes from 734c2b950..406a79acf
097d0ff 
406a79acf Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d8 Set GOMODCACHE to avoid re-download toolchain
98f23071d Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d0 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff66 Remove --kube-root deprecated kind argument
18b6ac6d2 chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pohly @k8s-ci-robot @msau42