Cherry-pick of #296: "Leader election: disable duplicate LE in provisioner lib; add lock namespacing" #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/S
…r election processes from running; Leader election namespacing
verult
force-pushed
the
leaderelection-disable-in-lib-1.12
branch
from
d88dc44 to
5e7fe47
Compare
k8s-ci-robot
added
release-note
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
master: update release-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it: Today there are two leader election processes running - one defined in external-provisioner main, one enabled in the provisioner controller lib by default. I ran into this problem when I set leader election type to lease - the external provisioner tries to do both lease-based and endpoint-based LE.
Also adding the ability to restrict the lock resource to specific namespaces.
Does this PR introduce a user-facing change?: