Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller expand secret ref to PV #301

Merged

Conversation

ggriffiths
Copy link
Member

@ggriffiths ggriffiths commented Jun 18, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds in the ControllerExpandSecretRef to the PV.

Which issue(s) this PR fixes:
Fixes #278

Special notes for your reviewer:

  • I renamed prefixedResizerSecretNameKey to prefixedControllerExpandSecretNameKey . This naming matches the other secret key names (nodePublishSecretNameKey etc).
  • I also changed these keys to be controller-expand-secret-name-key and controller-expand-secret-namespace-key (to match the other key naming).
  • I can change these keys back if needed (although we haven't documented them yet)
  • This change also updates k8s.io/api to latest in release-1.15 branch. I did this with an [[override]] instead of updating all dependencies to also have the release-1.15 dep constraint.

Does this PR introduce a user-facing change?:

The resizer secret name and namespace keys have been changed from the following values:
csi.storage.k8s.io/resizer-secret-name
csi.storage.k8s.io/resizer-secret-namespace

to be the following values:
csi.storage.k8s.io/controller-expand-secret-name
csi.storage.k8s.io/controller-expand-secret-namespace

This is a breaking change and is being introduced so that these keys match the naming convention for other secret name/namespace keys.

Signed-off-by: Grant Griffiths <ggp493@gmail.com>
Signed-off-by: Grant Griffiths <ggp493@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 18, 2019
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 June 18, 2019 23:05
@k8s-ci-robot
Copy link
Contributor

Hi @ggriffiths. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 18, 2019
@ggriffiths
Copy link
Member Author

/assign msau42
/assign gnufied

@msau42
Copy link
Collaborator

msau42 commented Jun 19, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2019
@msau42
Copy link
Collaborator

msau42 commented Jun 19, 2019

Renaming the secret is fine since resizing is still an alpha feature. Can you add a release note for this and note that it's a breaking change?

@@ -47,6 +47,10 @@
# because of the lack of semantic versioning in Kubernetes. Therefore we
# have to pick a certain release, otherwise we (more or less randomly) end
# up with something older or master.
[[override]]
name = "k8s.io/api"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm surprised client-go didn't need to be updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I found this override block makes it possible. It's more of a temporary fix until all other dependencies update to k8s.io/api 1.15.
https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md#override

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 19, 2019
@msau42
Copy link
Collaborator

msau42 commented Jun 20, 2019

/approve

Will let @gnufied lgtm

Can you also specify in the release note what the old key names were?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@gnufied
Copy link
Contributor

gnufied commented Jun 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit f4b4ab1 into kubernetes-csi:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Update external-provisioner to set resize secrets on resizing when necessary
4 participants