Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.3 changelog #305

Merged
merged 2 commits into from
Jun 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions CHANGELOG-1.3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Changelog since v1.2.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to compare against 1.2.0 (which was prematurely released), or 1.2.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should follow what Kubernetes does and its 1.14 changelog starts with Changelog since v1.13.0


## Breaking Changes

- The alpha resizer secret name and namespace keys have been changed from the following values:
- `csi.storage.k8s.io/resizer-secret-name`
- `csi.storage.k8s.io/resizer-secret-namespace`

to be the following values:
- `csi.storage.k8s.io/controller-expand-secret-name`
- `csi.storage.k8s.io/controller-expand-secret-namespace`

This is a breaking change and is being introduced so that these keys match the naming convention for other secret name/namespace keys. ([#301](https://github.com/kubernetes-csi/external-provisioner/pull/301), [@ggriffiths](https://github.com/ggriffiths))

## New Features

- A new flag `--leader-election-namespace` is introduced to allow the user to set where the leader election lock resource lives. ([#296](https://github.com/kubernetes-csi/external-provisioner/pull/296), [@verult](https://github.com/verult))
- Adds CSI Migration support for Azure Disk/File, adds some backwards compatibility fixes for GCE PD Migration ([#292](https://github.com/kubernetes-csi/external-provisioner/pull/292), [@davidz627](https://github.com/davidz627))
- Add `--strict-topology` option that restricts requisite topology to the selected node topology during delayed binding ([#282](https://github.com/kubernetes-csi/external-provisioner/pull/282), [@avalluri](https://github.com/avalluri))
- Add volume provisioning secret templating for storage class parameters: `csi.storage.k8s.io/provisioner-secret-name` and `csi.storage.k8s.io/provisioner-secret-namespace` ([#274](https://github.com/kubernetes-csi/external-provisioner/pull/274), [@ggriffiths](https://github.com/ggriffiths))
- Adds the ability to handle PVC as a DataSource to enable cloning for plugins that support it. ([#220](https://github.com/kubernetes-csi/external-provisioner/pull/220), [@j-griffith](https://github.com/j-griffith))

## Bug Fixes

- Fixes issue where leader election in the CSI provisioner and lib-external-provisioner conflicts. ([#296](https://github.com/kubernetes-csi/external-provisioner/pull/296), [@verult](https://github.com/verult))


18 changes: 8 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,22 @@ The external-provisioner is an external controller that monitors `PersistentVolu

This information reflects the head of this branch.

| Compatible with CSI Version | Container Image | Min K8s Version |
| Compatible with CSI Version | Container Image | Recommended K8s Version |
| ------------------------------------------------------------------------------------------ | -------------------------------| --------------- |
| [CSI Spec v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | quay.io/k8scsi/csi-provisioner | 1.14 |
| [CSI Spec v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | quay.io/k8scsi/csi-provisioner | 1.15 |

## Feature status

Various external-provisioner releases come with different alpha / beta features. Check `--help` output for alpha/beta features in each release.

Following table reflects the head of this branch.

| Feature | Status | Default | Description |
| -------------- | ------- | ------- | --------------------------------------------------------------------------------------------- |
| Topology | Beta | Off | [Topology aware dynamic provisioning](https://kubernetes-csi.github.io/docs/topology.html) (requires kubelet 1.14 on nodes). |
| Snapshots* | Alpha | On | [Snapshots and Restore](https://kubernetes-csi.github.io/docs/snapshot-restore-feature.html). |
| CSIMigration** | Alpha | On | [Migrating in-tree volume plugins to CSI](https://kubernetes.io/docs/concepts/storage/volumes/#csi-migration). |

*) There is no special feature gate for snapshots. It is enabled by running [external-snapshotter](https://github.com/kubernetes-csi/external-snapshotter/) and creating its CRDs.
**) There is no special feature gate for CSI migration. It is enabled by turning on CSI migration in Kubernetes.
| Feature | Status | Default | Description | Provisioner Feature Gate Required |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a feature for resize? Or why are resize keys mentioned in this changelog?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note about resize is referring to taking the storageclass resize secrets parameter and setting it in the PV object when provisioning. I don't think that's worth calling out as a feature as we do it for all other operation secrets

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

| -------------- | ------- | ------- | --------------------------------------------------------------------------------------------- | --------------------------------- |
| Topology | Beta | Off | [Topology aware dynamic provisioning](https://kubernetes-csi.github.io/docs/topology.html) (requires kubelet 1.14 on nodes). | Yes |
| Snapshots | Alpha | On | [Snapshots and Restore](https://kubernetes-csi.github.io/docs/snapshot-restore-feature.html). | No |
| CSIMigration | Alpha | On | [Migrating in-tree volume plugins to CSI](https://kubernetes.io/docs/concepts/storage/volumes/#csi-migration). | No |
| Cloning | Alpha | On | [Cloning](https://kubernetes-csi.github.io/docs/volume-cloning.html). | No |

All other external-provisioner features and the external-provisioner itself is considered GA and fully supported.

Expand Down