fix storageclass comparion for pvc datasource

[j-griffith]

/kind bug

What this PR does / why we need it:

Compare storage class string, instead of comparing
the string address.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com

Which issue(s) this PR fixes:

Fixes #308

Special notes for your reviewer:

Backport from master to 1.3

Does this PR introduce a user-facing change?:

NONE

[j-griffith]

/assign @msau42

[msau42]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-griffith, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhucan]

@j-griffith @msau42 what's about the image version that I can use for clone?

[j-griffith]

@j-griffith @msau42 what's about the image version that I can use for clone?

@zhucan You'll need at least 1.4.0-rc1 of the provisioner to include this bug fix.

[zhucan]

@j-griffith copy that, thanks. I have a question that if I have created a pvc by external-provisioner(version is v1.1.0), I can't do clone for the pvc by new external-provisioner(version is v1.4.0-rc1)? There are some logs for it

[zhucan]

@j-griffith logs:
Warning ProvisioningFailed 32s (x6 over 63s) ebs.csi.com_csi-sidecar-ebs-provisioner-7477947f5c-2zqb7_6a4a2d34-c2f7-11e9-a7e3-ca1815fa2d2c failed to provision volume with StorageClass "expand-sc": error getting handle for DataSource Type PersistentVolumeClaim by Name csi-pvc9: the source PVC (csi-pvc9) storageclass cannot be empty

[j-griffith]

@j-griffith logs:
Warning ProvisioningFailed 32s (x6 over 63s) ebs.csi.com_csi-sidecar-ebs-provisioner-7477947f5c-2zqb7_6a4a2d34-c2f7-11e9-a7e3-ca1815fa2d2c failed to provision volume with StorageClass "expand-sc": error getting handle for DataSource Type PersistentVolumeClaim by Name csi-pvc9: the source PVC (csi-pvc9) storageclass cannot be empty

@zhucan version used during create of the source shouldn't matter at all; That message you show in the logs indicates that there is no SC set in the destination PVC being created. If you do in fact have an SC set in the new PVC spec or there is a default class that should be picked up you may have found a bug.

I'd suggest opening a GH issue with some details including your yaml files.

[zhucan]

@j-griffith ok