Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to snapshot v3client #529

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Update to snapshot v3client #529

merged 1 commit into from
Nov 19, 2020

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Nov 17, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates snapshot dependency to v3/client.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use snapshot v3/client

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 17, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 17, 2020
@xing-yang xing-yang force-pushed the test_move_to_snapshot_v3client branch from 3335eee to 5049c32 Compare November 17, 2020 18:55
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2020
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-19-on-kubernetes-master

@xing-yang xing-yang force-pushed the test_move_to_snapshot_v3client branch from c1cb7e5 to 8d12c5e Compare November 18, 2020 05:23
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-19-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-alpha-1-19-on-kubernetes-1-19

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-alpha-1-19-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-18-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-17-on-kubernetes-master

@xing-yang xing-yang changed the title WIP: Update to snapshot v3client Update to snapshot v3client Nov 18, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2020
@xing-yang
Copy link
Contributor Author

/assign @msau42
/assign @yuxiangqian

msau42
msau42 reviewed Nov 18, 2020
View reviewed changes
go.mod Outdated
@@ -7,7 +7,7 @@ require (
github.com/golang/mock v1.4.3
github.com/kubernetes-csi/csi-lib-utils v0.8.1
github.com/kubernetes-csi/csi-test/v3 v3.1.1
github.com/kubernetes-csi/external-snapshotter/client/v2 v2.2.0-rc3
github.com/kubernetes-csi/external-snapshotter/client/v3 v3.0.1-0.20201116082704-1e5a7ef7a73d
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why there's a hash afterwards instead of just "v3.0.1"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I do a go get with the snapshot commit go get github.com/kubernetes-csi/external-snapshotter/client/v3@1e5a7ef7a73d691da0e6d350ba9613b05244d78f and that will generate this hash automatically when it picks that commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't really cut a 3.0.1 release for the client so it will not be just 3.0.1. The latest official release is 3.0.0 for the client.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we import v3.0.0 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably fine too.

@xing-yang xing-yang force-pushed the test_move_to_snapshot_v3client branch from 8d12c5e to 404cdef Compare November 19, 2020 04:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 19, 2020
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-19-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-alpha-1-19-on-kubernetes-1-19

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-alpha-1-19-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-18-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-17-on-kubernetes-master

@msau42
Copy link
Collaborator

msau42 commented Nov 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2020
@msau42
Copy link
Collaborator

msau42 commented Nov 19, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 535c255 into kubernetes-csi:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@yuxiangqian yuxiangqian

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xing-yang @msau42 @k8s-ci-robot @yuxiangqian