Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.1.1 CHANGELOG #747

Merged
merged 1 commit into from
Jun 14, 2022
Merged

v3.1.1 CHANGELOG #747

merged 1 commit into from
Jun 14, 2022

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jun 9, 2022

What type of PR is this?
/kind documentation

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2022
jingxu97
jingxu97 reviewed Jun 9, 2022
View reviewed changes
CHANGELOG/CHANGELOG-3.1.md
## Changes by Kind

### Bug or Regression
- Storage capacity: managed-by label potentially too long with a long node name and enableNodeDeployment set to true ([#739](https://github.com/kubernetes-csi/external-provisioner/pull/739), [@akalenyu](https://github.com/akalenyu))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is the only critical bug we want to fix in a patch release? Just want to understand how we pick which one to include or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user asked for it. There is no systematic triaging of bugs and no automatic backporting of bugs.

From https://kubernetes-csi.github.io/docs/project-policies.html (emphasis mine):

Every minor release branch will be supported with patch releases on an as-needed basis for at least 1 year

@humblec
Copy link
Contributor

humblec commented Jun 10, 2022 •
edited
Loading

@pohly are we planning 4.0.0 with all other enhancements soon ? and this meant for only one bug fix available patch release?

@pohly
Copy link
Contributor Author

pohly commented Jun 10, 2022

are we planning 4.0.0 with all other enhancements soon ?

There's going to be a 3.2.0 from the code in master.

and this meant for only one bug fix available patch release?

Yes.

@jingxu97
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2022
@pohly
Copy link
Contributor Author

pohly commented Jun 11, 2022

/assign @jsafrane

For approval.

@pohly
Copy link
Contributor Author

pohly commented Jun 14, 2022

/hold

Let's backport all bug fixes from 3.2.0:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@pohly
Copy link
Contributor Author

pohly commented Jun 14, 2022

/hold cancel

Additional backport PRs were merged, changelog was updated.

@jingxu97 : please re-add LGTM

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@jsafrane
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, jsafrane, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@pohly
Copy link
Contributor Author

pohly commented Jun 14, 2022

@jsafrane: can you also LGTM?

@jingxu97
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit fdfd8a3 into kubernetes-csi:release-3.1 Jun 14, 2022
pohly added a commit that referenced this pull request Jun 14, 2022
@pohly
fix changelog for v3.1.1
9082101 
PR #747 was merged
without refreshing it first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 jingxu97 left review comments

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

Assignees

@jsafrane jsafrane

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pohly @humblec @jingxu97 @jsafrane @k8s-ci-robot