Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/onsi/ginkgo/v2 from 2.7.1 to 2.8.1 #871

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2023

Bumps github.com/onsi/ginkgo/v2 from 2.7.1 to 2.8.1.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.8.1

2.8.1

Fixes

  • lock around default report output to avoid triggering the race detector when calling By from goroutines [2d5075a]
  • don't run ReportEntries through sprintf [febbe38]

Maintenance

  • Bump golang.org/x/tools from 0.5.0 to 0.6.0 (#1135) [11a4860]
  • test: update matrix for Go 1.20 (#1130) [4890a62]
  • Bump golang.org/x/sys from 0.4.0 to 0.5.0 (#1133) [a774638]
  • Bump github.com/onsi/gomega from 1.25.0 to 1.26.0 (#1120) [3f233bd]
  • Bump github-pages from 227 to 228 in /docs (#1131) [f9b8649]
  • Bump activesupport from 6.0.6 to 6.0.6.1 in /docs (#1127) [6f8c042]
  • Update index.md with instructions on how to upgrade Ginkgo [833a75e]

v2.8.0

2.8.0

Features

  • Introduce GinkgoHelper() to track and exclude helper functions from potential CodeLocations [e19f556]

Modeled after testing.T.Helper(). Now, rather than write code like:

func helper(model Model) {
    Expect(model).WithOffset(1).To(BeValid())
    Expect(model.SerialNumber).WithOffset(1).To(MatchRegexp(/[a-f0-9]*/))
}

you can stop tracking offsets (which makes nesting composing helpers nearly impossible) and simply write:

func helper(model Model) {
    GinkgoHelper()
    Expect(model).To(BeValid())
    Expect(model.SerialNumber).To(MatchRegexp(/[a-f0-9]*/))
}
  • Introduce GinkgoLabelFilter() and Label().MatchesLabelFilter() to make it possible to programmatically match filters (fixes #1119) [2f6597c]

You can now write code like this:

BeforeSuite(func() {
	if Label("slow").MatchesLabelFilter(GinkgoLabelFilter()) {
		// do slow setup
</tr></table> 

... (truncated)

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.8.1

Fixes

  • lock around default report output to avoid triggering the race detector when calling By from goroutines [2d5075a]
  • don't run ReportEntries through sprintf [febbe38]

Maintenance

  • Bump golang.org/x/tools from 0.5.0 to 0.6.0 (#1135) [11a4860]
  • test: update matrix for Go 1.20 (#1130) [4890a62]
  • Bump golang.org/x/sys from 0.4.0 to 0.5.0 (#1133) [a774638]
  • Bump github.com/onsi/gomega from 1.25.0 to 1.26.0 (#1120) [3f233bd]
  • Bump github-pages from 227 to 228 in /docs (#1131) [f9b8649]
  • Bump activesupport from 6.0.6 to 6.0.6.1 in /docs (#1127) [6f8c042]
  • Update index.md with instructions on how to upgrade Ginkgo [833a75e]

2.8.0

Features

  • Introduce GinkgoHelper() to track and exclude helper functions from potential CodeLocations [e19f556]

Modeled after testing.T.Helper(). Now, rather than write code like:

func helper(model Model) {
    Expect(model).WithOffset(1).To(BeValid())
    Expect(model.SerialNumber).WithOffset(1).To(MatchRegexp(/[a-f0-9]*/))
}

you can stop tracking offsets (which makes nesting composing helpers nearly impossible) and simply write:

func helper(model Model) {
    GinkgoHelper()
    Expect(model).To(BeValid())
    Expect(model.SerialNumber).To(MatchRegexp(/[a-f0-9]*/))
}
  • Introduce GinkgoLabelFilter() and Label().MatchesLabelFilter() to make it possible to programmatically match filters (fixes #1119) [2f6597c]

You can now write code like this:

BeforeSuite(func() {
	if Label("slow").MatchesLabelFilter(GinkgoLabelFilter()) {
		// do slow setup
	}
</tr></table>

... (truncated)

Commits
  • c7e3ebe v2.8.1
  • 2d5075a lock around default report output to avoid triggering the race detector when ...
  • febbe38 don't run ReportEntries through sprintf
  • 11a4860 Bump golang.org/x/tools from 0.5.0 to 0.6.0 (#1135)
  • 4890a62 test: update matrix for Go 1.20 (#1130)
  • a774638 Bump golang.org/x/sys from 0.4.0 to 0.5.0 (#1133)
  • 3f233bd Bump github.com/onsi/gomega from 1.25.0 to 1.26.0 (#1120)
  • f9b8649 Bump github-pages from 227 to 228 in /docs (#1131)
  • 6f8c042 Bump activesupport from 6.0.6 to 6.0.6.1 in /docs (#1127)
  • 833a75e Update index.md with instructions on how to upgrade Ginkgo
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.7.1 to 2.8.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.7.1...v2.8.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 14, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2023
@dependabot dependabot bot requested review from chrishenzie and jingxu97 February 14, 2023 06:06
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from pohly February 14, 2023 06:06
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit cd81ed5 into master Feb 14, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.8.1 branch February 14, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants