-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error format in VolumeSnapshotError #970
Comments
Another option is to record |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is your feature request related to a problem?/Why is this needed
In kanister controller https://github.com/kanisterio/kanister when creating volume snapshots we monitor its status to detect whether it's ready or failed.
When extracting the error from
VolumeSnapshotError.Message
it's just a string, usually composed with multiple layers of error strings.We'd like to be able to distinguish between different types of errors (e.g. recoverable and non-recoverable), but currently all we can do is to match the error text.
Describe the solution you'd like in detail
The type of
VolumeSnapshotError
can be extended to include something like error type or code.For example:
Alternatively formatting of error message in
VolumeSnapshotError.Message
can be changed to include error type while keeping it a string.Describe alternatives you've considered
Currently alternative is to match on error string, which is harder to maintain because text could be changed.
Additional context
The text was updated successfully, but these errors were encountered: