Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment regarding the validation checks #544

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Update comment regarding the validation checks #544

merged 1 commit into from
Jul 20, 2021

Conversation

RaunakShah
Copy link
Contributor

@RaunakShah RaunakShah commented Jul 7, 2021 •
edited by xing-yang
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This PR updates a comment.
Although #187 was closed, we want to keep the check in the controller since the validation webhook may not have been deployed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from ggriffiths and pohly July 7, 2021 08:02
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2021
@RaunakShah
Copy link
Contributor Author

/assign @xiangqian

@k8s-ci-robot
Copy link
Contributor

@RaunakShah: GitHub didn't allow me to assign the following users: xiangqian.

Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @xiangqian

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 7, 2021
@pohly
Copy link
Contributor

pohly commented Jul 7, 2021

/unassign

I'm not familiar with this code. Can someone else review?

xing-yang
xing-yang reviewed Jul 7, 2021
View reviewed changes
pkg/common-controller/snapshot_controller.go
@@ -96,17 +96,6 @@ func (ctrl *csiSnapshotCommonController) syncContent(content *crdv1.VolumeSnapsh
return err
}

// TODO(xiangqian): Putting this check in controller as webhook has not been implemented
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still in favor of keeping this check as the validation webhook may not be deployed. @yuxiangqian what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this for backwards compatibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. Let's leave it there but update the. comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2021
@ggriffiths
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaunakShah, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit e6e14c1 into kubernetes-csi:master Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 13, 2021
@xing-yang xing-yang changed the title Remove redundant validation checks Update comment regarding the validation checks Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxiangqian yuxiangqian yuxiangqian left review comments

@xing-yang xing-yang xing-yang left review comments

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@pohly pohly Awaiting requested review from pohly

Assignees

@xing-yang xing-yang

@ggriffiths ggriffiths

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaunakShah @k8s-ci-robot @pohly @ggriffiths @xing-yang @yuxiangqian