Fix deadlock in recursive metric locks #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RecordMetrics() grabs a mutex and calls recordCancelMetric(), which wants to grab the same mutex. Go mutexes are not recursive, so recordCancelMetric blocks forever. recordCancelMetric should not grab the mutex, it can be sure that the caller did it already.
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This was referenced Aug 19, 2021
|
/assign @ggriffiths |
|
/test pull-kubernetes-csi-external-snapshotter-1-21-on-kubernetes-1-21 |
|
/lgtm If this does not get rid of the deadlocks, feel free to revert my original PR and I can take a closer look after my PTO. |
k8s-ci-robot
added
the
lgtm
|
Looks like the pull-kubernetes-csi-external-snapshotter-1-21-on-kubernetes-1-21 job is not blocking the merge. The job is still pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
RecordMetrics()grabs a mutex and callsrecordCancelMetric(), which wants to grab the same mutex. Go mutexes are not recursive, sorecordCancelMetricblocks forever.recordCancelMetricshould not grab the mutex, all its callers already have the mutex.Which issue(s) this PR fixes:
Fixes #580
Does this PR introduce a user-facing change?: