Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency #14

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Conversation

sbezverk
Copy link
Contributor

Updating CSI to 0.3.0 annd testing travis
Signed-off-by: Serguei Bezverkhi sbezverk@cisco.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2018
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali August 14, 2018 00:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbezverk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 14, 2018
@sbezverk
Copy link
Contributor Author

@saad-ali I updated dependency to csi 0.3.0, let me know what exactly needed to close #13

@jsafrane
Copy link
Contributor

$ go test $(go list ./... | grep -v vendor)
# github.com/kubernetes-csi/livenessprobe/cmd
cmd/livenessprobe_test.go:25:2: cannot find package "github.com/golang/mock/gomock" in any of:
	/home/travis/gopath/src/github.com/kubernetes-csi/livenessprobe/vendor/github.com/golang/mock/gomock (vendor tree)
	/home/travis/.gimme/versions/go1.9.7.linux.amd64/src/github.com/golang/mock/gomock (from $GOROOT)
	/home/travis/gopath/src/github.com/golang/mock/gomock (from $GOPATH)

But I can see vendor/github.com/golang/mock/gomock in the PR...

@sbezverk
Copy link
Contributor Author

@jsafrane looks like it is passing now.

@sbezverk
Copy link
Contributor Author

@jsafrane @saad-ali I added unit test and e2e positive and negative tests, PTAL

@sbezverk sbezverk force-pushed the travis_tests branch 5 times, most recently from 96f36ba to 0b95594 Compare August 15, 2018 03:15
@jsafrane
Copy link
Contributor

lgtm-ish, please squash the commits a bit

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
@sbezverk
Copy link
Contributor Author

@jsafrane done PTAL

@jsafrane
Copy link
Contributor

Commit message "Code changes" is not very useful, but for this time...

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 42797a2 into kubernetes-csi:master Aug 15, 2018
pohly pushed a commit to pohly/livenessprobe that referenced this pull request Apr 11, 2019
prow.sh: remove AllAlpha=all, part II
jsafrane pushed a commit to jsafrane/livenessprobe that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants