-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing http-endpoint #96
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: verult The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you fix the tests? Otherwise this looks good to me! Thanks |
0d057ef
to
8bc04a5
Compare
@verult: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I'm trying to figure out where the liveness probe spec comes from in these presubmits. If it's from here, wondering if there's a way to overwrite flags in the presubmit job. |
Unfortunately there's no easy way to overwrite the flag. The options are to (1) keep the old flags and (2) force merge and cut a release right after. (1) is less disruptive. Drafted a new PR with another configuration of old+new flag behavior: #99 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it: Replacement of #95. Replaces
metrics-address
andhealth-port
flags withhttp-endpoint
.Special notes for your reviewer: Requires a major version bump.
Does this PR introduce a user-facing change?:
/assign @Jiawei0227 @msau42