RFC: enable JSON output and contextual logging #259
Conversation
The k8s.io/component-base/logs API is used to add several new command line
flags and the corresponding implementation:
-log-flush-frequency duration Maximum number of seconds between log flushes (default 5s)
-log-json-info-buffer-size quantity [Alpha] In JSON format with split output streams, the info messages can be buffered for a while to increase performance. The default value of zero bytes disables buffering. The size can be specified as number of bytes (512), multiples of 1000 (1K), multiples of 1024 (2Ki), or powers of those (3M, 4G, 5Mi, 6Gi). Enable the LoggingAlphaOptions feature gate to use this.
-log-json-split-stream [Alpha] In JSON format, write error messages to stderr and info messages to stdout. The default is to write a single stream to stdout. Enable the LoggingAlphaOptions feature gate to use this.
35a42
-logging-format string Sets the log format. Permitted formats: "json" (gated by LoggingBetaOptions), "text". (default "text")
In contrast to the defaults in the (pretty conservative) Kubernetes components,
contextual logging and alpha logging options get enabled by default. Without
a -feature-gate parameter they would not be usable otherwise.
Adding a -feature-gate parameter would be possible, but seems unnecessary
for these features.
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
| c := logsapi.NewLoggingConfiguration() | ||
| var pFlagSet pflag.FlagSet | ||
| logsapi.AddFlags(c, &pFlagSet) | ||
| pFlagSet.VisitAll(func(f *pflag.Flag) { |
There was a problem hiding this comment.
Can be replaced with logsapi.AddGoFlags.
|
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
JSON output can be parsed more reliably. Contextual logging is an opportunity to make log messages more consistent, also when using the traditional text format. It also makes output in unit tests better because the output gets associated with the test that produced it.
Special notes for your reviewer:
This currently only has one commit for enabling JSON output. Rewriting log calls to use contextual logging would be the next step (either in this PR or separately).
The k8s.io/component-base/logs API is used to add several new command line flags and the corresponding implementation:
In contrast to the defaults in the (pretty conservative) Kubernetes components, contextual logging and alpha logging options get enabled by default. Without a -feature-gate parameter they would not be usable otherwise.
Adding a -feature-gate parameter would be possible, but seems unnecessary for these features.
Does this PR introduce a user-facing change?: