This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
Enhancements to helm template #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add script to regenerate test/expected files from examples - Rename test/expected to generated_examples
k8s-ci-robot
added
cncf-cla: yes
cofyc
force-pushed
the
fix946
branch
2 times, most recently
from
437287d to
e20f2d8
Compare
- Change DaemonSet template to use apps/v1 - Able to create namespace.
|
cc @msau42 in case you missed it |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
cofyc
pushed a commit
to cofyc/external-storage
that referenced
this pull request
Dec 17, 2018
Enhancements to helm template
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #946
/assign @msau42
createNamespaceis true, I found most helm charts does this way, create if it's not default/kube-system/kube-public, may override pre-created namespace. On deletion, helm will delete that namespace).Add Daemonset option for a node selector(already implemented in Add support for nodeSelector constraint for Helm DaemonSet template #1022)