Remove false alarm on a volume with infinite inodes #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some storage systems, such as a CephFS filesystem, the underlying storage doesn't have any limit on inodes. If the kubelet_volume_stats_inodes_free metric is always zero, then the KubePersistentVolumeInodesFillingUp alert will always fire. This patch adds a simple conditional to ensure that the kubelet_volume_stats_inodes_free is meaningful for the volume and thus fixing the false alert on this edge case.
|
I believe that it was fixed in the Ceph CSI driver by ceph/ceph-csi#3407. |
|
Looks indeed like it. I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some storage systems, such as a CephFS filesystem, the underlying storage doesn't have any limit on inodes.
If the kubelet_volume_stats_inodes_free metric is always zero, then the KubePersistentVolumeInodesFillingUp alert will always fire.
This patch adds a simple conditional to ensure that the kubelet_volume_stats_inodes_free is meaningful for the volume and thus fixing the false alert on this edge case.