Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Update OWNERS #1000

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Update OWNERS #1000

merged 2 commits into from
Oct 13, 2018

Conversation

aaronlevy
Copy link
Contributor

We haven't updated this in a very long time, but moving to the upstream k8s approvals process which uses this. Updating to more recent direct maintainers.

cc @dghubble -- any interest in being added to this list?

We haven't updated this in a very long time, but moving to the upstream k8s approvals process which uses this. Updating to more recent direct maintainers.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2018
@spiffxp
Copy link
Contributor

spiffxp commented Oct 3, 2018

/lgtm
@rphillips you should be able to /approve and then this will merge.

Note that the tku-bookube-e2e-* tests aren't listed as required for merge so they're not going to be paid attention to. If they need to be, you can open a PR into k/test-infra

This is what is currently listed as required https://github.com/kubernetes/test-infra/blob/master/prow/config.yaml#L255-L258

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2018
@dghubble
Copy link
Contributor

@aaronlevy sure, sgtm

@dghubble
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@dghubble: changing LGTM is restricted to assignees, and only kubernetes-incubator/bootkube repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Contributor

spiffxp commented Oct 10, 2018

@dghubble file an issue on kubernetes/org and we'll get you added as a member so that works

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2018
@aaronlevy
Copy link
Contributor Author

@dghubble updated this to include you. I also sent an invite to be a collaborator on this repo -- that might be enough to get the bot to like you (and/or can join the incubator org as well).

@rphillips mind lgtm'ing?

@rphillips
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018
@rphillips
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@spiffxp
Copy link
Contributor

spiffxp commented Oct 13, 2018

tide Pending — Not mergeable. Jobs tku-bootkube-e2e-calico, tku-bootkube-e2e-flannel have not succeeded.

It's not clear to me why tide is paying attention to the failing job contexts; they aren't listed as Required for merge? I'm going to manually merge this since there are other examples of PR's where this is happening, and I'd like to get your updated OWNERS file in.

@spiffxp spiffxp merged commit bf8c232 into master Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants