-
Notifications
You must be signed in to change notification settings - Fork 224
Conversation
We haven't updated this in a very long time, but moving to the upstream k8s approvals process which uses this. Updating to more recent direct maintainers.
/lgtm Note that the This is what is currently listed as required https://github.com/kubernetes/test-infra/blob/master/prow/config.yaml#L255-L258 |
@aaronlevy sure, sgtm |
/lgtm |
@dghubble: changing LGTM is restricted to assignees, and only kubernetes-incubator/bootkube repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dghubble file an issue on kubernetes/org and we'll get you added as a member so that works |
@dghubble updated this to include you. I also sent an invite to be a collaborator on this repo -- that might be enough to get the bot to like you (and/or can join the incubator org as well). @rphillips mind lgtm'ing? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's not clear to me why tide is paying attention to the failing job contexts; they aren't listed as Required for merge? I'm going to manually merge this since there are other examples of PR's where this is happening, and I'd like to get your updated OWNERS file in. |
We haven't updated this in a very long time, but moving to the upstream k8s approvals process which uses this. Updating to more recent direct maintainers.
cc @dghubble -- any interest in being added to this list?