Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

WIP: Bump v1.12.1 #1002

Closed
wants to merge 3 commits into from
Closed

WIP: Bump v1.12.1 #1002

wants to merge 3 commits into from

Conversation

tomkukral
Copy link
Contributor

Update Kubernetes to v1.12.1 and update CoreDNS to 1.2.2.

@tomkukral
Bump v1.12.1
8ac2ef7 
Update Kubernetes dependencies to 1.12.1 and update CoreDNS to 1.2.2
@coreosbot
Copy link

Can one of the admins verify this patch?

2 similar comments
@coreosbot
Copy link

Can one of the admins verify this patch?

@coreosbot
Copy link

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2018
@coreosbot
Copy link

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aaronlevy

If they are not already assigned, you can assign the PR to them by writing /assign @aaronlevy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor

Thank you for the PR. We are currently tracking an issue with the pod checkpointer on 1.12.x. Did you see the same issue?

@tomkukral
Copy link
Contributor Author

@rphillips We are using just bootstrap part without checkpoing so it isn't affecting us. I'll make this WIP and try to help you with #1001

@tomkukral tomkukral changed the title Bump v1.12.1 WIP: Bump v1.12.1 Oct 11, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2018
@rphillips
Copy link
Contributor

currently this PR is failing on compile:

vendor/k8s.io/client-go/tools/clientcmd/client_config.go:187:3: undefined: mergo.MergeWithOverwrite

@rphillips
Copy link
Contributor

I pushed the mergo tweak to this PR.

@dghubble dghubble mentioned this pull request Oct 11, 2018
Closed
2 tasks
@coreosbot
Copy link

Can one of the admins verify this patch?

1 similar comment
@coreosbot
Copy link

Can one of the admins verify this patch?

@tomkukral
Copy link
Contributor Author

Similar to #1003

@tomkukral
Copy link
Contributor Author

Closing as duplicate of #1003

@tomkukral tomkukral closed this Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@rphillips rphillips Awaiting requested review from rphillips

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomkukral @coreosbot @k8s-ci-robot @rphillips