Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Add logger package to build container #59

Merged

Conversation

ashish-amarnath
Copy link
Contributor

What this PR does / why we need it:
Post #27 building capd-manager images require logger dir to be added to the build container.
Without this publish-manager.sh fails.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #58

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2019
@k8s-ci-robot k8s-ci-robot requested review from chuckha and justinsb July 3, 2019 07:25
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2019
@detiber
Copy link
Contributor

detiber commented Jul 3, 2019

/lgtm
longer term we'll want to update the dockerfile to use distroless, but since that complicates debugging we should probably hold off until this has been baked longer.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@chuckha
Copy link
Contributor

chuckha commented Jul 3, 2019

yep, i should add a verify to build the docker image 🤔 will add an issue
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashish-amarnath, chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit fda30b8 into kubernetes-retired:master Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish-manager.sh fails without the logging package in the build container
4 participants