Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

docs: update readme #7

Merged
merged 2 commits into from
Jun 21, 2019
Merged

docs: update readme #7

merged 2 commits into from
Jun 21, 2019

Conversation

sethp-nr
Copy link
Contributor

Also changes the sample to use controlplane to match what the manager
is looking for.

@sethp-nr
docs: update readme
552d73d 
Also changes the sample to use `controlplane` to match what the manager
is looking for.
@k8s-ci-robot
Copy link
Contributor

Welcome @sethp-nr!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-docker 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-docker has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2019
@k8s-ci-robot k8s-ci-robot requested review from detiber and vincepri June 21, 2019 19:05
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2019
@sethp-nr
Copy link
Contributor Author

/assign @chuckha

chuckha
chuckha reviewed Jun 21, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor suggestion

README.md Outdated Show resolved Hide resolved
@sethp-nr @chuckha
docs: kind >0.3.0
a65a240 
Not 0.30.0

Co-Authored-By: Chuck Ha <ha.chuck@gmail.com>
@chuckha
Copy link
Contributor

chuckha commented Jun 21, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, sethp-nr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit d81278a into kubernetes-retired:master Jun 21, 2019
@sethp-nr sethp-nr deleted the docs/update-readme branch June 21, 2019 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckha chuckha chuckha left review comments

@detiber detiber Awaiting requested review from detiber

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@chuckha chuckha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethp-nr @k8s-ci-robot @chuckha