This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler: cloud provider interface implementation for GCE #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwielgus
force-pushed
the
gce-provider
branch
3 times, most recently
from
f689c13
to
cd74019
Compare
|
|
||
| // AddNodeGroup adds node group defined in string spec. Format: | ||
| // minNodes:maxNodes:migUrl | ||
| func (gce *GceCloudProvider) AddNodeGroup(spec string) error { |
There was a problem hiding this comment.
Shouldn't this be passed in a constructor? Do you have any use case for adding NodeGroup in flight?
| } | ||
|
|
||
| // Url builds GCE url for the MIG. | ||
| func (mig *Mig) Url() string { |
There was a problem hiding this comment.
Why do you need this? It's equivalent to Id().
mwielgus
force-pushed
the
gce-provider
branch
2 times, most recently
from
94e886a
to
4d22a72
Compare
| // IncreaseSize increases Mig size | ||
| func (mig *Mig) IncreaseSize(delta int) error { | ||
| if delta <= 0 { | ||
| return fmt.Errorf("size increase must be positive") |
There was a problem hiding this comment.
so why not making delta uint?
There was a problem hiding this comment.
suppose that someone has -1 in an int variable. Stupid int->uint conversion would make it some huge number that added to the current size couple lines below would effectively mean -1. In this way -1 would pass through the checks.
mwielgus
force-pushed
the
gce-provider
branch
3 times, most recently
from
fe08aef
to
678951d
Compare
|
LGTM |
| } | ||
|
|
||
| // Belongs retruns true if the given node belongs to the NodeGroup. | ||
| func (mig *Mig) Belongs(node *kube_api.Node) (bool, error) { |
There was a problem hiding this comment.
@mwielgus Does this method need to be exported?
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…provider Cluster-autoscaler: cloud provider interface implementation for GCE
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…provider Cluster-autoscaler: cloud provider interface implementation for GCE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @piosz @fgrzadkowski @jszczepkowski
Part of #1311