This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler: use cloud provider interface in the code #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwielgus
force-pushed
the
use-cloud-provider
branch
3 times, most recently
from
2f1dd1d
to
103022f
Compare
|
LGTM |
mwielgus
force-pushed
the
use-cloud-provider
branch
from
103022f
to
2cf2808
Compare
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…cloud-provider Cluster-autoscaler: use cloud provider interface in the code
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…cloud-provider Cluster-autoscaler: use cloud provider interface in the code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus remove SampleNode() function from CloudProvider interface.
Ref: #1311
cc: @iterion @piosz @fgrzadkowski @jszczepkowski