This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
AWS Cluster Autoscaler: NodeGroupForNode should return nil if instance is not in any known ASG #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
|
@k8s-bot test this |
@andrewsykim Please run the above command and push the new version. |
andrewsykim
force-pushed
the
aws-ca-bug-instance-not-in-known-group
branch
from
9e34255
to
fa8d4cd
Compare
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @andrewsykim @mwielgus |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Sep 12, 2016
Automatic merge from submit-queue Bump cluster autoscaler to 0.3 Almost no changes comparing to 0.3.0-beta6. Just a minor fix in AWS support: kubernetes-retired/contrib#1721.
pwittrock
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Sep 13, 2016
Automatic merge from submit-queue Bump cluster autoscaler to 0.3 Almost no changes comparing to 0.3.0-beta6. Just a minor fix in AWS support: kubernetes-retired/contrib#1721. (cherry picked from commit bfef4ad)
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
Automatic merge from submit-queue Bump cluster autoscaler to 0.3 Almost no changes comparing to 0.3.0-beta6. Just a minor fix in AWS support: kubernetes-retired/contrib#1721. (cherry picked from commit bfef4ad)
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…a-bug-instance-not-in-known-group AWS Cluster Autoscaler: NodeGroupForNode should return nil if instance is not in any known ASG
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…a-bug-instance-not-in-known-group AWS Cluster Autoscaler: NodeGroupForNode should return nil if instance is not in any known ASG
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1311
We ran into a bug where the
CheckGroupsAndNodescheck fails once we added a second ASG to our cluster that was not maintained by CA. And that's because inGetAsgForInstancewe should be returning a nil group if the instance doesn't belong to any of the groups that the CA is aware of.This change is