This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 92
deploy: add README, fix typos #124
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| The .yaml files in this directory depend on the RBAC files that were | ||
| released together the CSI sidecar containers. Check the repos and/or | ||
| release notes for the CSI sidecar containers for details. | ||
|
|
||
| https://kubernetes-csi.github.io/docs/ has an example that puts all | ||
| pieces together. | ||
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the rbac rules should be copied into examples/hostpath so that a hostpath deployment can be done using the YAML files. The docs will eventually point to the hostpath repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, please not. Having to keep files in sync in different repos is exactly the kind of maintenance headache that we are currently trying to get rid of.
The Example.md is self-contained without copies because it references upstream files via URL. I have a PR pending for Kubernetes E2E which achieves the same (kubernetes/kubernetes#71703). Let's not go in the other direction here.
The deployment here won't be complete, but it doesn't have to be. That's what the Example.md is for - IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I personally would have preferred a solution where all relevant .yaml files are in the same repo because then they can be updated and tested together. But it was decided that each component maintainer is also responsible for maintaining the corresponding .yaml files (in particular the RBAC files), which is why we now move the individual files away from centralized places (docs, kubernetes E2E) into individual repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with your last comment re: having all yamls in the same repo. My thought was to have all yamls that are necessary to standup a hostpath instance under
hostpath/exampleinstead ofdocs/examplesto minimize. I think when the config yamls are located in docs/examples, it may not be clear that they need updated as hostpath changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving from kubernetes-csi/docs is good. Then eventually kubernetes-csi/docs will just reference files elsewhere by URL.
But do you really mean all yamls, including the RBAC ones from driver-registrar, external-attacher and external-provisioner? That goes against the decision made earlier, so before you do that, discuss it in the CSI standup.
In the meantime, can we merge this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave RBAC files in sidecar container repos (external-provisioner, external-attacher, etc.).
Each driver can provide it's own YAMLs for DeamonSet/ReplicaSet, along with a deployment script that deploys all the YAMLs (including the RBAC ones).