Etcd snapshot dep. failed do download because it moved folders

[xistoso]

Fixes #191 snapshot dependency changed to clientv3

In de following commit etcd moved files to clientv3 folder. So snapshot dependency should be this one.

Thanks for @neolit123 for pointing out the right path on comment

Created a new cluster successfuly with a snapshot of a running kubernetes

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @xistoso!

It looks like this is your first PR to kubernetes-sigs/etcdadm 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/etcdadm has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @xistoso. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

thanks @xistoso

cla/linuxfoundation — commit missing GitHub user

please note that this commit e228b5b

needs to be authored by people who have signed the CLA.

you also have the option to refactor the commit to be authored by a single github user that have signed the CLA and give credit to other people in the commit message.

[xistoso]

Yeah @neolit123 i noticed that. I don't khow how to remove the root authoring. I updated the commit locally and force pushed. But it got 2 authors now.

[xistoso]

I signed it

[neolit123]

cla/linuxfoundation — xistoso authorized

seems good.

/ok-to-test
/lgtm

[neolit123]

/assign @dlipovetsky

[dlipovetsky]

@xistoso Thanks for reporting this issue and filing the PR.

@neolit123 Thanks for reviewing. Do you think this the right fix? I see that go get -u sigs.k8s.io/etcdadm pulls the latest minor version of etcd (v3.4.x as of now). If an etcd minor versions can move package that etcdadm depends on, should etcdadm pin a specific minor version of etcd?

[neolit123]

@xistoso
please see the minor gofmt error:

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_etcdadm/152/pull-etcdadm-verify/1227017063466274820

 
 	"github.com/coreos/etcd/clientv3"
+	"github.com/coreos/etcd/clientv3/snapshot"
 	"github.com/coreos/etcd/etcdserver/etcdserverpb"
 	"github.com/coreos/etcd/pkg/transport"
-	"github.com/coreos/etcd/clientv3/snapshot"

@dlipovetsky

should etcdadm pin a specific minor version of etcd?

the following repository technically no longer exists:

	github.com/coreos/etcd v3.3.13+incompatible

and it now redirects to:
https://github.com/etcd-io/etcd

k/k is pinning using a SHA pointing at go.etcd.io/etcd:
https://github.com/kubernetes/kubernetes/blob/master/go.mod#L487
due to:
kubernetes/kubernetes#87613 (comment)
and etcdadm should do the same IMO.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[neolit123]

@xistoso just try to fix the https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_etcdadm/152/pull-etcdadm-verify/1227601105404301313 error.
we can work on the etcd location switch later.

[neolit123]

also please keep the commits squashed to 1 (using e.g. git push -f)

[dlipovetsky]

k/k is pinning using a SHA pointing at go.etcd.io/etcd:
https://github.com/kubernetes/kubernetes/blob/master/go.mod#L487
due to:
kubernetes/kubernetes#87613 (comment)
and etcdadm should do the same IMO.

Agreed. Thanks for setting me straight 😃

[neolit123]

this LGTM. we can change the import location in a separate PR if someone wants to take this.

[dlipovetsky]

Thanks @xistoso for the PR and @neolit123 for the review.

/lgtm

[dlipovetsky]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky, xistoso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlipovetsky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment