Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Update to go 1.19.5 #365

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Update to go 1.19.5 #365

merged 1 commit into from
Feb 6, 2023

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Feb 4, 2023

Also requires a bazel update.

@justinsb
Update to go 1.19.5
9e4d26c 
Also requires a bazel update.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2023
hakman
hakman reviewed Feb 4, 2023
View reviewed changes
etcd-manager/.bazelversion
@@ -1 +1 @@
4.2.1
5.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel requires new images for cloudbuild, which didn't exist until recently:
https://github.com/kubernetes-sigs/etcdadm/blob/master/etcd-manager/cloudbuild.yaml

See: bazelbuild/continuous-integration#1060 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch - thanks - I'll take a look.

It would be great to get off bazel - it's kinda silly that to build with the newer go we need to update the tasks, and they require updating bazel, and that requires a cloudbuild image. Just too many pieces in the chain there!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. For now, #366 should fix the promotion.

@hakman
Copy link
Contributor

hakman commented Feb 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit f6e8cdb into kubernetes-retired:master Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hakman hakman hakman left review comments

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @hakman