Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Move lib to https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner #1026

Merged
merged 6 commits into from
Nov 1, 2018
Merged

Move lib to https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner #1026

merged 6 commits into from
Nov 1, 2018

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Oct 16, 2018 •
edited
Loading

Delete lib directory.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 16, 2018
@wongma7 wongma7 force-pushed the sig-storage branch 6 times, most recently from 120dafa to 0c5189f Compare October 17, 2018 22:39
@wongma7 wongma7 changed the title WIP: move lib to https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner Move lib to https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner Oct 18, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2018
@iawia002
Copy link
Contributor

Some files in sig-storage-lib-external-provisioner are not the latest version

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 19, 2018

@iawia002 oops, should be fixed now, thanks!

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 19, 2018

@childsb @jsafrane PTAL . Is putting a "deprecation notice" in lib/README.md sufficient or should I remove all of lib?

@wongma7
Copy link
Contributor Author

wongma7 commented Nov 1, 2018

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

@wongma7: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@wongma7 wongma7 added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Nov 1, 2018

lgtm'd offline, merging

@k8s-ci-robot k8s-ci-robot merged commit a88e8ba into kubernetes-retired:master Nov 1, 2018
cofyc pushed a commit to cofyc/external-storage that referenced this pull request Dec 17, 2018
@k8s-ci-robot
Merge pull request kubernetes-retired#1026 from wongma7/sig-storage
23916e9 
Move lib to https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner
@warmchang
Copy link

Hi @wongma7
Does the document deleted by commit have been transferred to sig-storage-lib-external-provisioner repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@childsb childsb Awaiting requested review from childsb

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/lib cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wongma7 @iawia002 @k8s-ci-robot @warmchang