This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
Make nfs-client ARM deployment consistent with regular deployment. #1090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happen to be using the nfs-client provisioner for a project which runs Kubernetes on both ARM and AMD64 platforms, so I was trying to see what differences there were in the deployment (since there's one specific for ARM).
A
diff
showed a number of differences, but it seems that they are probably just the result of the two manifests getting out of sync (especially evidenced by the fact that the ARM manifest uses the deprecatedserviceAccount
instead ofserviceAccountName
).I've made it so the ARM manifest matches the normal one; the only difference is the addition of the
-arm
to the end of the image name (which I've preserved).Merging this PR will help people be able to see the exact, (currently) single difference between the templates to help them template the manifest or just to understand what's different.
I'm not sure what 'ifs' is, but I figure it's better to be consistent with the primary deployment manifest than have something that makes sense to me :)