This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
CephFS provisioner use provisioner name as identitiy by default instead of random string #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and support `PROVISIONER_NAME` envionment variable. See kubernetes-retired#267.
k8s-ci-robot
added
the
cncf-cla: yes
|
@cofyc: GitHub didn't allow me to request PR reviews from the following users: rootfs. Note that only kubernetes-incubator members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yangruiray
pushed a commit
to yangruiray/external-storage
that referenced
this pull request
Jul 19, 2019
…ramsMap solve misleading struct deprecatedSecretParamsMap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See #267.
Special notes for your reviewer:
In this PR, I also add
PROVISIONER_NAMEenvironment variable support, like many other provisioners do./cc @rootfs @wongma7