Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Upgrade kubernetes dependencies to 1.9.2 #578

Merged

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jan 26, 2018

What this PR does / why we need it:

Upgrade kubernetes dependencies to 1.9.2. Some features requires 1.9.x API definitions. See #552, #570.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for reviewer:

I splited the PR into two parts:

  • Vendor files: 92504da (glide up -v followed by glide-vc --use-lock-file)
  • Non-vendor changes: c7537cc

Due to some packages depending to packages under k8s.io/kubernetes which changed a lot, a lot of conflicts need to be fixed:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 26, 2018
@cofyc cofyc force-pushed the upgrade_kubernetes_to_1.9.x branch 2 times, most recently from 38e3c19 to b975861 Compare January 26, 2018 15:30
@cofyc
Copy link
Contributor Author

cofyc commented Jan 26, 2018

/assign @wongma7

- k8s.io/kubernetes/pkg/api/v1/helper -> k8s.io/kubernets/pkg/apis/core/v1/helper
- Remove Scheme.DeepCopy, see kubernetes/kubernetes#53525
- Move global scheme to pkg/api/legacyscheme, see kubernetes/kubernetes#53984
- Add hack scripts to update CRD deepcopy generated files to 1.9.2.
@humblec
Copy link
Contributor

humblec commented Feb 2, 2018

Thanks @cofyc !

@humblec
Copy link
Contributor

humblec commented Feb 2, 2018

@wongma7 As all the tests are passed, it looks good to me. PTAL.

@hswong3i
Copy link
Contributor

hswong3i commented Feb 4, 2018

Thanks @cofyc confirm that ceph/cephfs could be compile successfully ;-)

@hswong3i
Copy link
Contributor

hswong3i commented Feb 6, 2018

@cofyc and @wongma7 may we have another stable image for CephFS provisioner pushing to https://quay.io/repository/external_storage/cephfs-provisioner once getting ready?

I am now trying to integrate CephFS provisioner with Kubespray (kubernetes-sigs/kubespray#2230), which temporarily require for building local image and push to a local registry. Without the help from here, the integration procedure for Kubespray now looks absolutely insane...

@rootfs
Copy link
Contributor

rootfs commented Feb 7, 2018

lgtm
cc @tsmetana @xing-yang for snapshot crd

@rootfs
Copy link
Contributor

rootfs commented Feb 7, 2018

locally built but not tested. Would like to cut a release and then merge it.

@childsb @jsafrane @wongma7

@childsb
Copy link
Contributor

childsb commented Feb 7, 2018

I cut a release with the 1.8 deps here: https://github.com/kubernetes-incubator/external-storage/releases

I'll merge this to update deps to 1.9

@childsb childsb merged commit 92295a3 into kubernetes-retired:master Feb 7, 2018
@cofyc cofyc deleted the upgrade_kubernetes_to_1.9.x branch February 8, 2018 02:34
cofyc pushed a commit to cofyc/external-storage that referenced this pull request Dec 17, 2018
…es_to_1.9.x

Upgrade kubernetes dependencies to 1.9.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants