Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

[nfs-client]Remove redundant field in the rbac.yaml of nfs-client #970

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

gobomb
Copy link
Contributor

@gobomb gobomb commented Sep 6, 2018

When I run the command kubectl create -f external-storage/nfs-client/deploy/rbac.yaml, I got some error like this:

```
error: error validating "rbac.yaml": error validating data: ValidationError(ClusterRole.rules[4]): missing required field "verbs" in io.k8s.api.rbac.v1.PolicyRule; if you choose to ignore these errors, turn validation off with --validate=false

```

I found that after removing the redundant field - apiGroups: [""], the command works fine.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 6, 2018
@liangxia
Copy link
Contributor

liangxia commented Sep 7, 2018

/LGTM

@k8s-ci-robot
Copy link
Contributor

@liangxia: changing LGTM is restricted to assignees, and only kubernetes-incubator/external-storage repo collaborators may be assigned issues.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gobomb gobomb changed the title Remove redundant field in the rbac.yaml of nfs-client [nfs-client]Remove redundant field in the rbac.yaml of nfs-client Sep 10, 2018
@gobomb
Copy link
Contributor Author

gobomb commented Sep 10, 2018

/area nfs-client

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Sep 12, 2018

/lgtm

oops, thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@wongma7 wongma7 merged commit 32cf16d into kubernetes-retired:master Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/nfs-client cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants