This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Support portmapping #162
Merged
Support portmapping #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
heartlock
force-pushed
the
support-portmapping
branch
from
fbce34e
to
f0aab8c
Compare
Signed-off-by: heartlock <21521209@zju.edu.cn>
heartlock
force-pushed
the
support-portmapping
branch
from
f0aab8c
to
12875ef
Compare
feiskyer
reviewed
Jun 8, 2017
| HostPort int32 `json:"hostPort"` | ||
| ContainerPort int32 `json:"containerPort"` | ||
| Protocol string `json:"protocol"` | ||
| HostIP string `json:"hostIP"` |
feiskyer
reviewed
Jun 8, 2017
hack/test-e2e.sh
Outdated
| { | ||
| "type": "portmap", | ||
| "capabilities": {"portMappings": true}, | ||
| "snat": false |
There was a problem hiding this comment.
should be true here, refer https://github.com/containernetworking/plugins/tree/master/plugins/meta/portmap#snat
feiskyer
reviewed
Jun 8, 2017
| @@ -88,32 +88,44 @@ function install_remote_hyperd() { | |||
| function configure_cni() { | |||
| # install cni | |||
There was a problem hiding this comment.
could you also update the CNI setup in README.md?
Signed-off-by: heartlock <21521209@zju.edu.cn>
heartlock
force-pushed
the
support-portmapping
branch
from
12875ef
to
3cc4b06
Compare
Signed-off-by: heartlock <21521209@zju.edu.cn>
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
@feiskyer Thanks for your help! Ready for review.
Closes: #122