This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
Fix an issue when memory/bytes_used is not reported. #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export both evictable and non-evictable metrics.
|
This change is |
k8s-ci-robot
added
size/M
| "memory_type": "evictable", | ||
| } | ||
| return ts | ||
| case core.MetricMemoryWorkingSet.MetricDescriptor.Name: |
There was a problem hiding this comment.
For my own education - where does this name come from?
There was a problem hiding this comment.
core.MetricMemoryWorkingSet is a metric that we fetch from kubelet. At the same time bytes_used (and minor_page_faults) are created manually in preprocessMemoryMetrics function.
|
/lgtm |
|
LGTM provided Stackdriver confirmed this metric will work with label |
aleksandra-malinowska
approved these changes
Sep 29, 2017
|
/approve |
This was referenced Sep 29, 2017
|
@loburm nice fix. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export both evictable and non-evictable metrics.